Skip to content

Addition of "fallback" Variation to the NameController for Petnames#3705

Merged
dbrans merged 2 commits into
mainfrom
dbrans/name-fallback-variation
Jan 4, 2024
Merged

Addition of "fallback" Variation to the NameController for Petnames#3705
dbrans merged 2 commits into
mainfrom
dbrans/name-fallback-variation

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented Jan 3, 2024

Explanation

In this PR, we introduced a "fallback" variation (denoted as "*") in the NameController specifically for the handling of petnames. In the case of ethereum addresses, variations typically are the hexadecimal chainID, implicitly defining petnames for a specific address within a particular chain.

The rationale behind adding a fallback variation is to accommodate scenarios where the petnames are not strictly tied to a particular chain. Instead of enforcing a chain-specific petname, the fallback variation operates on a more flexible rule: Given an Ethereum address, if a chain-specific petname does not exist, the fallback variation is automatically inspected to determine if a petname exists for this general scenario.

References

Changelog

@metamask/name-controller

  • ADDED: Fallback variation for petnames

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@dbrans dbrans added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Jan 3, 2024
@dbrans dbrans self-assigned this Jan 3, 2024
@dbrans dbrans marked this pull request as ready for review January 3, 2024 19:15
@dbrans dbrans requested a review from a team as a code owner January 3, 2024 19:15
@dbrans
Copy link
Copy Markdown
Contributor Author

dbrans commented Jan 3, 2024

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 3, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "7.0.0-preview.c9a5f6a5",
  "@metamask-previews/address-book-controller": "3.1.6-preview.c9a5f6a5",
  "@metamask-previews/announcement-controller": "5.0.1-preview.c9a5f6a5",
  "@metamask-previews/approval-controller": "5.1.1-preview.c9a5f6a5",
  "@metamask-previews/assets-controllers": "23.0.0-preview.c9a5f6a5",
  "@metamask-previews/base-controller": "4.0.1-preview.c9a5f6a5",
  "@metamask-previews/build-utils": "1.0.1-preview.c9a5f6a5",
  "@metamask-previews/composable-controller": "5.0.0-preview.c9a5f6a5",
  "@metamask-previews/controller-utils": "8.0.1-preview.c9a5f6a5",
  "@metamask-previews/ens-controller": "8.0.0-preview.c9a5f6a5",
  "@metamask-previews/eth-json-rpc-provider": "2.3.1-preview.c9a5f6a5",
  "@metamask-previews/gas-fee-controller": "12.0.0-preview.c9a5f6a5",
  "@metamask-previews/json-rpc-engine": "7.3.1-preview.c9a5f6a5",
  "@metamask-previews/json-rpc-middleware-stream": "6.0.1-preview.c9a5f6a5",
  "@metamask-previews/keyring-controller": "11.0.0-preview.c9a5f6a5",
  "@metamask-previews/logging-controller": "2.0.1-preview.c9a5f6a5",
  "@metamask-previews/message-manager": "7.3.7-preview.c9a5f6a5",
  "@metamask-previews/name-controller": "4.0.1-preview.c9a5f6a5",
  "@metamask-previews/network-controller": "17.1.0-preview.c9a5f6a5",
  "@metamask-previews/notification-controller": "4.0.1-preview.c9a5f6a5",
  "@metamask-previews/permission-controller": "7.0.0-preview.c9a5f6a5",
  "@metamask-previews/permission-log-controller": "0.0.0-preview.c9a5f6a5",
  "@metamask-previews/phishing-controller": "8.0.1-preview.c9a5f6a5",
  "@metamask-previews/polling-controller": "4.0.0-preview.c9a5f6a5",
  "@metamask-previews/preferences-controller": "5.0.1-preview.c9a5f6a5",
  "@metamask-previews/queued-request-controller": "0.3.0-preview.c9a5f6a5",
  "@metamask-previews/rate-limit-controller": "4.0.1-preview.c9a5f6a5",
  "@metamask-previews/selected-network-controller": "6.0.0-preview.c9a5f6a5",
  "@metamask-previews/signature-controller": "9.0.0-preview.c9a5f6a5",
  "@metamask-previews/transaction-controller": "19.0.0-preview.c9a5f6a5",
  "@metamask-previews/user-operation-controller": "0.0.0-preview.c9a5f6a5"
}

@dbrans dbrans marked this pull request as draft January 3, 2024 20:23
@dbrans dbrans marked this pull request as ready for review January 4, 2024 15:10
dbrans added a commit to MetaMask/metamask-extension that referenced this pull request Jan 4, 2024
@dbrans dbrans merged commit 05e92ec into main Jan 4, 2024
@dbrans dbrans deleted the dbrans/name-fallback-variation branch January 4, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-confirmations-system DEPRECATED: please use "team-confirmations" label instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants