Addition of "fallback" Variation to the NameController for Petnames#3705
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
vinistevam
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In this PR, we introduced a "fallback" variation (denoted as "*") in the NameController specifically for the handling of petnames. In the case of ethereum addresses, variations typically are the hexadecimal chainID, implicitly defining petnames for a specific address within a particular chain.
The rationale behind adding a fallback variation is to accommodate scenarios where the petnames are not strictly tied to a particular chain. Instead of enforcing a chain-specific petname, the fallback variation operates on a more flexible rule: Given an Ethereum address, if a chain-specific petname does not exist, the fallback variation is automatically inspected to determine if a petname exists for this general scenario.
References
Changelog
@metamask/name-controllerChecklist