chore(preferences-controller): Clean up types#3712
Merged
Conversation
Gudahtt
force-pushed
the
clean-up-preferences-controller-types
branch
2 times, most recently
from
bb37cd1 to
320415c
Compare
3 tasks
The `PreferencesController` types are now declared as types rather than interfaces, in accordance with our conventions, and they are now fully documented. The state properties have also been alphabetized so that they are easier to maintain. Additionally, the old "ContactEntry" type has been renamed to "Identity", which is a more accurate name for what it is being used for here.
Gudahtt
force-pushed
the
clean-up-preferences-controller-types
branch
from
320415c to
0ffc8af
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
PreferencesControllertypes are now declared as types rather than interfaces, in accordance with our conventions, and they are now fully documented. The state properties have also been alphabetized so that they are easier to maintain.Additionally, the old "ContactEntry" type has been renamed to "Identity", which is a more accurate name for what it is being used for here.
References
This was an effort to reduce the scope of the BaseControllerV2 migration, tracked by #3708
Changelog
@metamask/preferences-controllerChanged
ContactEntryinterface withIdentitytypePreferencesStatefrom an interface to a typeChecklist