Add SubjectMetadataController:addSubjectMetadata action#3733
Merged
Conversation
FrederikBolding
changed the title
:addSubjectMetadata actionSubjectMetadataController:addSubjectMetadata action
david0xd
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
SubjectMetadataControlleris currently being called with a direct reference to the controller in the extension client: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/metamask-controller.js#L2367-L2373To simplify this and make it easier for the SnapController to handle the population of metadata, this PR adds an exposed action for
addSubjectMetadata.Changelog
@metamask/permission-controllerSubjectMetadataController:addSubjectMetadataactionChecklist