Skip to content

Fix typo #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2018
Merged

Fix typo #38

merged 2 commits into from
Dec 5, 2018

Conversation

brunobar79
Copy link
Contributor

This typo (🤦‍♂️ ) is making the app crash. My bad!

estebanmino
estebanmino approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this was making Android crash. LGTM

@brunobar79 brunobar79 merged commit db942b2 into master Dec 5, 2018
@whymarrh whymarrh deleted the fix-crash branch November 5, 2019 17:43
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
@Mrtenz
Add coercion utils (MetaMask#38)
9df08d4 
* Add coercion utils

* Slightly improve docs

* Make coercions more strict and add more test cases

* Add note to valueToBytes
kanthesha pushed a commit that referenced this pull request Sep 19, 2023
@dependabot
Bump @metamask/auto-changelog from 3.0.0 to 3.1.0 (#38)
3b44a1a 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
@rekmarks
Add CircleCI config (#38)
c926423
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@MajorLift
Fix typo (#38)
c55c4d9 
* Fix typo

* fix wrong quotes
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 3.0.0 to 3.1.0 (#38)
a866c9d 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@MajorLift
Fix typo (#38)
600c529 
* Fix typo

* fix wrong quotes
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 3.0.0 to 3.1.0 (#38)
fe2875b 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MajorLift pushed a commit that referenced this pull request Oct 12, 2023
@dependabot @MajorLift
Bump @metamask/auto-changelog from 3.0.0 to 3.1.0 (#38)
5c295d8 
Bumps [@metamask/auto-changelog](https://github.com/MetaMask/auto-changelog) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/MetaMask/auto-changelog/releases)
- [Changelog](https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md)
- [Commits](MetaMask/auto-changelog@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/auto-changelog"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@danfinlay
Merge pull request #38 from MetaMask/safe-eventemitter
5d9427f 
feat: isolate blocktracker from event listener errors
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@rekmarks
5.0.1 (#38)
75a8f6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitpshr bitpshr Awaiting requested review from bitpshr

1 more reviewer

@estebanmino estebanmino estebanmino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brunobar79 @estebanmino