Skip to content

Release/110.0.0#3810

Merged
montelaidev merged 16 commits intomainfrom
release/110.0.0
Jan 23, 2024
Merged

Release/110.0.0#3810
montelaidev merged 16 commits intomainfrom
release/110.0.0

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 22, 2024 •
edited
Loading

Release the following packages:

@metamask/keyring-controller@12.1.0
@metamask/accounts-controller@9.0.0
@metamask/signature-controller@11.0.0

Confirmed there are no dependencies on unreleased code.

@montelaidev montelaidev requested a review from a team as a code owner January 22, 2024 15:15
@socket-security
Copy link

socket-security bot commented Jan 22, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@legobeat
Copy link
Contributor

legobeat commented Jan 22, 2024 •
edited
Loading

Some peerDeps need to be aligned (or exempted?):

➤ YN0024: @metamask/accounts-controller must depend on @metamask/keyring-controller via ^13.0.0, but uses ^12.0.0 instead (in dependencies)
➤ YN0053: @metamask/accounts-controller must depend on @metamask/keyring-controller via conflicting ranges ^13.0.0 and ^12.0.0 (in peerDependencies)
➤ YN0024: @metamask/signature-controller must depend on @metamask/keyring-controller via ^13.0.0, but uses ^12.0.0 instead (in dependencies)
➤ YN0053: @metamask/signature-controller must depend on @metamask/keyring-controller via conflicting ranges ^13.0.0 and ^12.0.0 (in peerDependencies)
➤ YN0000: Failed with errors in 3s 707ms
Error: Process completed with exit code 1.

https://github.com/MetaMask/core/actions/runs/7613357335/job/20733092582?pr=3810

legobeat
legobeat reviewed Jan 22, 2024
View reviewed changes
gantunesr
gantunesr reviewed Jan 22, 2024
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
@montelaidev
Copy link
Contributor Author

montelaidev commented Jan 22, 2024

Performed a force push, to align the peer dependencies.

Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
@montelaidev montelaidev changed the title Release/110.0.0 Release/109.1.0 Jan 22, 2024
@montelaidev montelaidev requested a review from Gudahtt January 22, 2024 17:30
Gudahtt
Gudahtt reviewed Jan 22, 2024
View reviewed changes
@montelaidev montelaidev changed the title Release/109.1.0 Release/11.0.0 Jan 23, 2024
@legobeat legobeat changed the title Release/11.0.0 Release/110.0.0 Jan 23, 2024
Gudahtt
Gudahtt reviewed Jan 23, 2024
View reviewed changes
Gudahtt
Gudahtt reviewed Jan 23, 2024
View reviewed changes
Gudahtt
Gudahtt previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt dismissed their stale review January 23, 2024 14:12

Recinding approval until #3820 is merged

Gudahtt
Gudahtt approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@montelaidev montelaidev merged commit 007648b into main Jan 23, 2024
@montelaidev montelaidev deleted the release/110.0.0 branch January 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@legobeat legobeat Awaiting requested review from legobeat

@gantunesr gantunesr Awaiting requested review from gantunesr

Assignees

No one assigned

Labels

team-accounts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@montelaidev @legobeat @Gudahtt @gantunesr @AlexJupiter