Selected network controller should update all domains when feature flag is off#3834
Merged
Selected network controller should update all domains when feature flag is off#3834
Conversation
jiexi
reviewed
Jan 24, 2024
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
6d34e68 to
2e3fbb4
Compare
jiexi
reviewed
Jan 25, 2024
jiexi
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When the feature flag for per dapp network is turned off, we should keep all the proxies for all the domains in sync. To do that, we add some code to the end of the function used to set network client id for a given domain. When the user is setting the domain for 'metamask', and when the feature flag is off, we do the update to all the domains, not just metamask.
References
Changelog
@metamask/selected-network-controllerChecklist