Skip to content

Selected network controller should update all domains when feature flag is off#3834

Merged
BelfordZ merged 4 commits intomainfrom
selected-network-controller-ff
Jan 25, 2024
Merged

Selected network controller should update all domains when feature flag is off#3834
BelfordZ merged 4 commits intomainfrom
selected-network-controller-ff

Conversation

@BelfordZ
Copy link
Contributor

Explanation

When the feature flag for per dapp network is turned off, we should keep all the proxies for all the domains in sync. To do that, we add some code to the end of the function used to set network client id for a given domain. When the user is setting the domain for 'metamask', and when the feature flag is off, we do the update to all the domains, not just metamask.

References

Changelog

@metamask/selected-network-controller

  • CHANGED: NetworkClientId for each domain will be the same as metamask when the feature flag is off

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ requested a review from a team as a code owner January 24, 2024 18:58
@BelfordZ BelfordZ force-pushed the selected-network-controller-ff branch from 6d34e68 to 2e3fbb4 Compare January 25, 2024 17:59
@BelfordZ BelfordZ requested a review from jiexi January 25, 2024 18:20
@BelfordZ BelfordZ merged commit df6e4e5 into main Jan 25, 2024
@BelfordZ BelfordZ deleted the selected-network-controller-ff branch January 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants