[composable-controller] Better typing for state, messenger, strict type checks for inputs, remove `#controllers` field#3904

Merged

MajorLift merged 25 commits intomainfrom

230207-fix-composable-controller

Feb 21, 2024

Commits on Feb 21, 2024

Add `@metamask/utils` to composable-controller deps
MajorLift
committed
Define and apply `isBaseController` type guard
MajorLift
committed
test: Add test for composing a non-controller
MajorLift
committed
Improve BaseControllerV1 typing, type guard, comments
MajorLift
committed
Remove unused `#controllers` class field
MajorLift
committed
Export base-controller type guards
MajorLift
committed
Remove deprecated `subscribe` property from BaseControllerV2
MajorLift
committed
Use `Record<string, Json>` typing for BaseControllerV2 state objects
MajorLift
committed
Use generic argument for typing `reduce`
MajorLift
committed
Update CHANGELOGs
MajorLift
committed
Refactor messenger typing for controller events and allowed events
MajorLift
committed
Add `isValidJson` check for child state from BaseControllerV2 controllers
MajorLift
committed
Update CHANGELOG
MajorLift
committed
Add `@metamask/json-rpc-engine` as devDep
MajorLift
committed
Revert "Remove deprecated `subscribe` property from BaseControllerV2"
MajorLift
committed
Update packages/base-controller/CHANGELOG.md
MajorLift
committed
Add TODOs for removing `BaseControllerV1` related features once all controllers have migrated to V2
MajorLift
committed
Remove `ControllerList` type, add `BaseControllerV{1,2}Instance` types
MajorLift
committed
Populate metadata object in constructor with child controllers
MajorLift
committed
Fix jsdoc
MajorLift
committed
Add jsdoc for types `BaseControllerV{1,2}Instance`, `ControllerInstance`
MajorLift
committed
Export types `ControllerInstance`, `BaseControllerV{1,2}Instance`
MajorLift
committed
Update packages/composable-controller/CHANGELOG.md

MajorLift
and
mcmire
committed
Update import statement for non-dependency to use `@metamask/` prefix

MajorLift
and
mcmire
committed
Linter fixes
MajorLift
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[composable-controller] Better typing for state, messenger, strict type checks for inputs, remove `#controllers` field#3904

[composable-controller] Better typing for state, messenger, strict type checks for inputs, remove `#controllers` field#3904
MajorLift merged 25 commits intomainfrom
230207-fix-composable-controller

Commits on Feb 21, 2024

Add `@metamask/utils` to composable-controller deps

Define and apply `isBaseController` type guard

test: Add test for composing a non-controller

Improve BaseControllerV1 typing, type guard, comments

Remove unused `#controllers` class field

Export base-controller type guards

Remove deprecated `subscribe` property from BaseControllerV2

Use `Record<string, Json>` typing for BaseControllerV2 state objects

Use generic argument for typing `reduce`

Update CHANGELOGs

Refactor messenger typing for controller events and allowed events

Add `isValidJson` check for child state from BaseControllerV2 controllers

Update CHANGELOG

Add `@metamask/json-rpc-engine` as devDep

Revert "Remove deprecated `subscribe` property from BaseControllerV2"

Update packages/base-controller/CHANGELOG.md

Add TODOs for removing `BaseControllerV1` related features once all controllers have migrated to V2

Remove `ControllerList` type, add `BaseControllerV{1,2}Instance` types

Populate metadata object in constructor with child controllers

Fix jsdoc

Add jsdoc for types `BaseControllerV{1,2}Instance`, `ControllerInstance`

Export types `ControllerInstance`, `BaseControllerV{1,2}Instance`

Update packages/composable-controller/CHANGELOG.md

Update import statement for non-dependency to use `@metamask/` prefix

Linter fixes