Listen to permissions changes and add/remove domains#3969
Merged
Conversation
BelfordZ
commented
Feb 23, 2024
adonesky1
reviewed
Feb 26, 2024
adonesky1
reviewed
Feb 26, 2024
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
adonesky1
reviewed
Feb 26, 2024
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
adonesky1
reviewed
Feb 26, 2024
Contributor
|
Looking good so far. Left some comments and lets get some tests for this new functionality 😄 |
…ller.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
BelfordZ
force-pushed
the
fix/permission-change-update-domains
branch
from
ff52293 to
199bda7
Compare
BelfordZ
changed the title
domains
adonesky1
reviewed
Feb 27, 2024
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
adonesky1
previously approved these changes
Feb 27, 2024
…ller.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
adonesky1
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here for more info: https://app.zenhub.com/workspaces/wallet-api-platform-63bee08a4e3b9d001108416e/issues/gh/metamask/metamask-planning/2142
Explanation
When there exists a permission for a domain, we will then start saving their network selection. We also retroactively add network selections for domains which already have permissions.
References
Changelog
@metamask/selected-network-controllerChecklist