Skip to content

remove redundant perDomainNetwork state#3989

Merged
adonesky1 merged 2 commits intomainfrom
fix/remove-redundant-state
Feb 27, 2024
Merged

remove redundant perDomainNetwork state#3989
adonesky1 merged 2 commits intomainfrom
fix/remove-redundant-state

Conversation

@BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Feb 27, 2024

Explanation

See here for more details

References

Changelog

@metamask/selected-network-controller

  • ADDED: SelectedNetworkController constructor now takes a getUseRequestQueue function.
  • REMOVED: SelectedNetworkController no longer has a perDappNetwork feature flag saved in state.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ marked this pull request as ready for review February 27, 2024 21:36
@BelfordZ BelfordZ requested a review from a team as a code owner February 27, 2024 21:36
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 17c52d9 into main Feb 27, 2024
@adonesky1 adonesky1 deleted the fix/remove-redundant-state branch February 27, 2024 23:17
@adonesky1
Copy link
Contributor

Just a note both of the changelog entries here are breaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants