Skip to content

move permission controller from devdep to regular dep#4000

Merged
BelfordZ merged 1 commit intomainfrom
fix-selected-network-deps
Feb 29, 2024
Merged

move permission controller from devdep to regular dep#4000
BelfordZ merged 1 commit intomainfrom
fix-selected-network-deps

Conversation

@BelfordZ
Copy link
Contributor

@BelfordZ BelfordZ commented Feb 29, 2024

Explanation

in response to #3996 (review)

References

Changelog

@metamask/selected-network-controller

  • CHANGED: Move permissions-controller from devDeps to deps and peerDep

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@BelfordZ BelfordZ requested a review from a team as a code owner February 29, 2024 18:22
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.

@mcmire mcmire mentioned this pull request Feb 29, 2024
3 tasks
@BelfordZ BelfordZ merged commit e7b3e4b into main Feb 29, 2024
@BelfordZ BelfordZ deleted the fix-selected-network-deps branch February 29, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants