Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / core Public

Notifications You must be signed in to change notification settings
Fork 276
Star 393

Code
Issues 295
Pull requests 236
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

[keyring-controller] Atomic Operations#4192

Merged

mikesposito merged 17 commits intomainMetaMask/core:mainfrom

feat/keyring-controller-atomic-operationsMetaMask/core:feat/keyring-controller-atomic-operationsCopy head branch name to clipboard

Apr 26, 2024

Conversation Commits17 (17)Checks Files changed

Merged

[keyring-controller] Atomic Operations#4192
mikesposito merged 17 commits intomainfrom
feat/keyring-controller-atomic-operations

Commits

Commits on Apr 26, 2024

feat: add `#asAtomicOperation`
mikesposito
committed
docs: add jsdoc
mikesposito
committed
refactor: execute `onSuccess` after releasing lock
mikesposito
committed
refactor: `persistAllKeyrings` let the wrapper update vault or rollback
mikesposito
committed
refactor: remove `#asAtomicOperation` options
mikesposito
committed
test: add test case
mikesposito
committed
refactor: rename to `#persistOrRollback`
mikesposito
committed
refactor: rollback keyrings from serialized array
mikesposito
committed
test: set jest coverage threshold
mikesposito
committed
refactor: roll back password
mikesposito
committed
refactor: split into `#withRollback` and `#persistOrRollback`
mikesposito
committed
test: adjust coverage threshold
mikesposito
committed
refactor: move `#clearKeyrings` into `#restoreSerializedKeyrings`
mikesposito
committed
test: use `exportAccount` instead of `getAccounts`
mikesposito
committed
remove leftover `#updateVault` call
mikesposito
committed
docs: add `MutuallyExclusiveCallback` tsdoc
mikesposito
committed
fix: preserve qr subscription
mikesposito
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.