Add semaphore when adding assets #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
approved these changes
Dec 11, 2018
mcmire
pushed a commit
to mcmire/core
that referenced
this pull request
Jul 17, 2023
* Add tests for Json type * Move test to src folder and get rid of test-d folder * Add tests for Hex type too * Exclude type tests from coverage
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* refactor to controllers and tests related to assets * add semaphore when adding assets * run asset detection with safely execute * use BN isZero
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* refactor to controllers and tests related to assets * add semaphore when adding assets * run asset detection with safely execute * use BN isZero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an edge case when an asset is added manually, while at the same time is being auto detected in the background. To solve this a semaphore is included in
addCollectibleandaddTokenmethods.It also includes a refactor of some controllers related to assets and their tests.