fix: add publish event in deleteNotificationsById and export snap types#4836
Merged
fix: add publish event in deleteNotificationsById and export snap types#4836
deleteNotificationsById and export snap types#4836Conversation
Prithpal-Sooriya
approved these changes
Oct 23, 2024
Merged
hmalik88
added a commit
that referenced
this pull request
Oct 23, 2024
Releasing `@metamask/notification-services-controller` to include #4836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
deleteNotificationsByIddoesn't fire an event with the updated list of notifications and thus, theupdateBadgefunction inside the extension is not fired.@metamask/notification-services-controllerdeleteNotificationsByIdfunction did not fire an event with the updated notifications list, this was added after the function runs through all the notifications it needs to delete.Checklist