feat: add useSafeChainsListValidation, tokenSortConfig and privacyMode#4860
Merged
cryptodev-2s merged 10 commits intoOct 30, 2024
Merged
Conversation
…e to PreferencesController state
Contributor
Author
|
This change will also simplify the patch in this bump MetaMask/metamask-mobile#12055 |
mcmire
reviewed
Oct 29, 2024
kanthesha
reviewed
Oct 29, 2024
| export type EtherscanSupportedHexChainId = | ||
| (typeof ETHERSCAN_SUPPORTED_CHAIN_IDS)[EtherscanSupportedChains]; | ||
|
|
||
| type TokenSortConfig = { |
Contributor
There was a problem hiding this comment.
nit.
do we need to export this type? will it be useful in the downstream.
Contributor
Author
There was a problem hiding this comment.
I don't think its required to be exported
…references-controller
…references-controller
Merged
7 tasks
…references-controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR add three new properties to PreferencesController state:
References
Changelog
@metamask/preferences-controllerAdded
useSafeChainsListValidationpreference (#4860)useSafeChainsListValidationproperty to thePreferencesControllerstate (default:true)setUseSafeChainsListValidationmethod to set this propertytokenSortConfigpreference (#4860)tokenSortConfigproperty to thePreferencesControllerstate (default value:{ key: 'tokenFiatAmount', order: 'dsc', sortCallback: 'stringNumeric' })setTokenSortConfigmethod to set this propertyprivacyModepreference (#4860)privacyModeproperty to thePreferencesControllerstate (default value:false)setPrivacyModemethod to set this propertyChecklist