Merged
Conversation
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/selected-network-controller@19.0.0 |
adonesky1
force-pushed
the
release/258.0.0
branch
from
145df02 to
b8a597b
Compare
mcmire
reviewed
Nov 25, 2024
|
|
||
| ### Removed | ||
|
|
||
| - `createQueuedRequestMiddleware` no longer takes a `useRequestQueue` parameter. All requests are now queued if `shouldEnqueueRequest(req)` returns true. ([#4941](https://github.com/MetaMask/core/pull/4941)) |
Contributor
There was a problem hiding this comment.
Removing this option will cause a type error if a client is still attempting to pass it, so should we mark it as a breaking change and release it under 8.0.0?
Contributor
Author
There was a problem hiding this comment.
Ah yes I suppose thats true. I'm used to doing this in JS in extension so never get these errors 😅
|
|
||
| ### Removed | ||
|
|
||
| - The `SelectedNetworkController` constructor no longer expects a `useRequestPreference` boolean nor an `onPreferencesStateChange` listener. Removal of these parameters means that `domains` state will always be added for sites that are granted permissions. ([#4941](https://github.com/MetaMask/core/pull/4941)) |
Contributor
There was a problem hiding this comment.
Similar as above, removing these options will cause type errors if they're still attempting to be passed. Should we release this under 20.0.0?
matthewwalsh0
previously approved these changes
Nov 26, 2024
adonesky1
force-pushed
the
release/258.0.0
branch
from
f01e72b to
0b5e6f5
Compare
adonesky1
force-pushed
the
release/258.0.0
branch
from
0b5e6f5 to
8907fc7
Compare
matthewwalsh0
previously approved these changes
Nov 26, 2024
Gudahtt
reviewed
Nov 26, 2024
Gudahtt
reviewed
Nov 26, 2024
Gudahtt
requested changes
Nov 26, 2024
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
Looks good! Two suggested additions, then I can approve this
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
matthewwalsh0
pushed a commit
that referenced
this pull request
Nov 26, 2024
## Changelog ### `@metamask/queued-request-controller` ## 7.1.0 ### Removed - `createQueuedRequestMiddleware` no longer takes a `useRequestQueue` parameter. All requests are now queued if `shouldEnqueueRequest(req)` returns true. ([#4941](#4941)) ### `@metamask/selected-network-controller ## 19.1.0 ### Removed - The `SelectedNetworkController` constructor no longer expects a `useRequestPreference` boolean nor an `onPreferencesStateChange` listener. Removal of these parameters means that `domains` state will always be added for sites that are granted permissions. ([#4941](#4941)) --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@metamask/queued-request-controller7.1.0
Removed
createQueuedRequestMiddlewareno longer takes auseRequestQueueparameter. All requests are now queued ifshouldEnqueueRequest(req)returns true. (#4941)`@metamask/selected-network-controller
19.1.0
Removed
SelectedNetworkControllerconstructor no longer expects auseRequestPreferenceboolean nor anonPreferencesStateChangelistener. Removal of these parameters means thatdomainsstate will always be added for sites that are granted permissions. (#4941)