feat: Allow capturing feature flags in debug snapshots#5004
Merged
Conversation
Gudahtt
force-pushed
the
allow-capturing-feature-flag-in-debug-snapshots
branch
from
7b396a2 to
feee9e8
Compare
7 tasks
DDDDDanica
approved these changes
Nov 29, 2024
Contributor
|
LGTM ! |
The controller metadata for the `RemoteFeatureFlagController` has been updated to declare the feature flag state as anonymous. These values are set by us and do not contain any PII. This allows us to capture this state in Sentry debug snapshots, which could be very useful for debugging.
Gudahtt
force-pushed
the
allow-capturing-feature-flag-in-debug-snapshots
branch
from
feee9e8 to
eee0bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The controller metadata for the
RemoteFeatureFlagControllerhas been updated to declare the feature flag state as anonymous. These values are set by us and do not contain any PII. This allows us to capture this state in Sentry debug snapshots, which could be very useful for debugging.References
N/A
Changelog
See changelog diff
Checklist