Fix unmocked block tracker warning in GasFeeController tests#5297
Merged
Conversation
When running the tests for GasFeeController, we were seeing a warning in the tests that a request from the block tracker was not properly mocked. This commit adds that mock so the warning goes away.
mcmire
force-pushed
the
fix-block-tracker-warning-in-gfc-tests
branch
from
3cc1a6f to
1d385da
Compare
mcmire
added
the
team-wallet-framework
Contributor
Author
|
@MetaMask/confirmations Can I get a review on this PR when you get a chance, thanks! |
OGPoyraz
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When running the tests for GasFeeController, we were seeing many warnings in the test output indicating that a request from the block tracker was not properly mocked. This commit adds that mock so the warning goes away.
References
Manual testing
mainand runyarn workspace @metamask/gas-fee-controller run test. See that there are a lot ofconsole.errorlines.console.errorlines.Checklist