feat: use withKeyring to get notification accounts for main keyring #5459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
force-pushed
the
MMASSETS-618/feat-add-get-notification-accounts-method
branch
from
94b73c7 to
bf2ca24
Compare
…d' and 'main' of github.com:MetaMask/core into MMASSETS-618/feat-add-get-notification-accounts-method
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
we can instead just use state to find accounts
Prithpal-Sooriya
force-pushed
the
MMASSETS-618/feat-add-get-notification-accounts-method
branch
from
c2a9ad3 to
8c51c6e
Compare
salimtb
reviewed
Mar 19, 2025
| 'KeyringController:withKeyring', | ||
| { | ||
| type: KeyringTypes.hd, | ||
| index: 0, |
Contributor
There was a problem hiding this comment.
why are we hardcoding index to 0 here ?
Contributor
Author
There was a problem hiding this comment.
Aha, copied from Identity Profile Sync Controllers.
The Keyring controller now supports multiple keyrings (importing multiple SRPs). So this indicates that we only want the first/main keyring.
gambinish
approved these changes
Mar 19, 2025
Prithpal-Sooriya
deleted the
MMASSETS-618/feat-add-get-notification-accounts-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
For notification settings, we only want to fetch accounts that our on the main keyring.
References
Changelog
@metamask/notification-services-controllerKeyringController:getAccountswithKeyringController:withKeyringChecklist