feat: SeedlessOnboarding Controller minor release (2.2.0) #6135
Conversation
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@lwin-kyaw I’ve added the do-not-merge label as I noticed some issues with this release and how it was prepared. Would you mind reviewing our release process outlined here? |
Hi @cryptodev-2s thanks for pointing out. I guess I forgot to update the package.json version number? |
Yes, that part was missing. We should always use |
Hi @cryptodev-2s, thanks for the info. I tried using that. But run into the error |
Yes, that package has been removed. It’s possible that some ignored files are still referenced locally—feel free to delete that directory manually. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
)" This reverts commit 3e9c32a.
## Explanation Ignore transactions with `isTransfer` set when checking for duplicate nonces in `PendingTransactionTracker`. ## References Related to [#6135](MetaMask/MetaMask-planning#6135) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Prevents pending transactions from being marked dropped when their nonce matches an incoming/transfer transaction by refining the nonce-taken check. > > - **PendingTransactionTracker**: > - Refine `#isNonceTaken` to exclude transactions where `tx.type !== incoming` AND `tx.isTransfer !== undefined`, avoiding false duplicate-nonce drops from incoming/transfer transactions. > - Add unit test ensuring no `transaction-dropped` event when a matching nonce belongs to an incoming transaction. > - **Changelog**: > - Document fix: prevent transactions marked as `dropped` if nonce matches incoming transaction. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 77e52f5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Explanation
Minor bump of SeedlessOnboardingController from
2.1.0to2.2.0.References
Changelog
Checklist