Feat/shield subscription controller#6233
Merged
chaitanyapotti merged 50 commits intomainfrom Aug 29, 2025
Merged
Conversation
tuna1207
requested review from
chaitanyapotti,
himanshuchawla009 and
tanguyenvn
matthiasgeihs
requested review from
matthiasgeihs
and removed request for
tanguyenvn
matthiasgeihs
requested changes
Aug 21, 2025
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
Please be mindful that more tests is not always better.
Having a lot of tests also means that applying changes to the functionality will require a lot of changes to the tests, which costs time.
When writing tests, make sure that you avoid code duplication and try to use a single setup function across a suite of tests, so that it's easy to change things in the setup without having to change it across all tests individually.
matthiasgeihs
requested changes
Aug 21, 2025
MajorLift
reviewed
Aug 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
matthiasgeihs
previously approved these changes
Aug 27, 2025
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
There is one untested branch, which is worthwhile testing and is also easy to test. Then you can adjust coverage thresholds to 100%.
Otherwise looks good 👍
matthiasgeihs
previously approved these changes
Aug 28, 2025
chaitanyapotti
previously approved these changes
Aug 28, 2025
tuna1207
dismissed stale reviews from chaitanyapotti and matthiasgeihs
via
41719fe
Member
Author
|
Hi @cryptodev-2s i have addressed the comments, please help me re-review the PR |
matthiasgeihs
approved these changes
Aug 28, 2025
chaitanyapotti
approved these changes
Aug 29, 2025
cryptodev-2s
approved these changes
Aug 29, 2025
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
LGTM! Could you please also his controller the Controller Metadata Survey
github-project-automation
Bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Create Shield Subscription controller
References
Changelog
Checklist