Skip to content

feat: subscription controller handle create with card#6300

Merged
chaitanyapotti merged 69 commits intomainfrom
feat/shield-subscription-create-with-card
Sep 2, 2025
Merged

feat: subscription controller handle create with card#6300
chaitanyapotti merged 69 commits intomainfrom
feat/shield-subscription-create-with-card

Conversation

@tuna1207
Copy link
Copy Markdown
Member

Explanation

Handle subscription controller start subscription with card

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Comment thread packages/subscription-controller/src/SubscriptionController.ts Outdated
cursor[bot]

This comment was marked as outdated.

chaitanyapotti
chaitanyapotti previously approved these changes Sep 1, 2025
@chaitanyapotti chaitanyapotti added the area-shield Transaction Shield label Sep 1, 2025
Comment thread packages/subscription-controller/src/SubscriptionController.ts Outdated
cursor[bot]

This comment was marked as outdated.

chaitanyapotti
chaitanyapotti previously approved these changes Sep 1, 2025
matthiasgeihs
matthiasgeihs previously approved these changes Sep 1, 2025
Copy link
Copy Markdown
Contributor

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments

Comment thread packages/subscription-controller/src/types.ts
Comment thread packages/subscription-controller/src/types.ts
Comment thread packages/subscription-controller/src/types.ts
Comment thread packages/subscription-controller/src/SubscriptionService.test.ts Outdated
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chaitanyapotti chaitanyapotti enabled auto-merge (squash) September 2, 2025 09:33
@chaitanyapotti chaitanyapotti merged commit ce41b58 into main Sep 2, 2025
235 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/shield-subscription-create-with-card branch September 2, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants