Skip to content

feat: SubscriptionController: get pricing#6356

Merged
matthiasgeihs merged 5 commits intomainfrom
mg/subscription-controller/fetch-product-price
Sep 3, 2025
Merged

feat: SubscriptionController: get pricing#6356
matthiasgeihs merged 5 commits intomainfrom
mg/subscription-controller/fetch-product-price

Conversation

@matthiasgeihs
Copy link
Copy Markdown
Contributor

@matthiasgeihs matthiasgeihs commented Aug 21, 2025

Explanation

Add a "getPricing" method to the SubscriptionController, which allows the frontend to query the available products and their pricing.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthiasgeihs matthiasgeihs force-pushed the mg/subscription-controller/fetch-product-price branch 2 times, most recently from eccf19a to 740b4dd Compare August 23, 2025 15:34
@matthiasgeihs matthiasgeihs marked this pull request as ready for review August 23, 2025 15:34
@matthiasgeihs matthiasgeihs requested review from a team as code owners August 23, 2025 15:35
cursor[bot]

This comment was marked as outdated.

@matthiasgeihs matthiasgeihs force-pushed the mg/subscription-controller/fetch-product-price branch 2 times, most recently from 5296f43 to aa6b7f4 Compare August 29, 2025 08:55
cursor[bot]

This comment was marked as outdated.

@matthiasgeihs matthiasgeihs force-pushed the mg/subscription-controller/fetch-product-price branch from aa6b7f4 to 647a986 Compare August 29, 2025 09:15
cursor[bot]

This comment was marked as outdated.

Base automatically changed from feat/shield-subscription-controller to main August 29, 2025 14:22
@chaitanyapotti chaitanyapotti added the area-shield Transaction Shield label Sep 2, 2025
@matthiasgeihs matthiasgeihs force-pushed the mg/subscription-controller/fetch-product-price branch 3 times, most recently from 7a74c3a to 4dfbfb0 Compare September 2, 2025 10:55
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need the types for individual items in this as mentioned here to be used in frotend. https://github.com/consensys-vertical-apps/va-mmcx-subscription-api/blob/main/src/subscriptions/dto/pricingDto.ts

Pls type out the same way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@matthiasgeihs matthiasgeihs force-pushed the mg/subscription-controller/fetch-product-price branch from 4872c5a to a0dea5c Compare September 3, 2025 13:28
@matthiasgeihs matthiasgeihs enabled auto-merge (squash) September 3, 2025 13:29
@matthiasgeihs matthiasgeihs merged commit c29a64c into main Sep 3, 2025
235 checks passed
@matthiasgeihs matthiasgeihs deleted the mg/subscription-controller/fetch-product-price branch September 3, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants