Skip to content

Conversation

@Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Sep 4, 2025

Explanation

Adds perp order notification support.

This is technically already supported here, but moving to core will reduce logic/complexity of setting up notifs.
https://github.com/MetaMask/metamask-mobile/blob/3428d076e871e1ab7a68978bcc2da9770c4200b7/app/components/UI/Perps/controllers/PerpsController.ts#L697

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review September 4, 2025 13:21
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners September 4, 2025 13:21
@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) September 4, 2025 16:25
@Prithpal-Sooriya Prithpal-Sooriya merged commit 2e4ac7f into main Sep 4, 2025
239 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the feat/add-perp-notifications-endpoint branch September 4, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants