chore: add whitelist to utils to ignore warnings for specific networks#6557
Merged
Julink-eth merged 11 commits intomainfrom Sep 15, 2025
Merged
chore: add whitelist to utils to ignore warnings for specific networks#6557Julink-eth merged 11 commits intomainfrom
Julink-eth merged 11 commits intomainfrom
Conversation
mcmire
reviewed
Sep 11, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
I have made some suggestions as it relates directly to these changes. However, have we considered porting over the chain collision check from the clients itself rather than just the mapping? If the goal is to consolidate the behavior around network validation then it seems like that would satisfy the goal in a more maintainable way. As it is, if we just bring over the mapping, we are allowing the behavior to deviate (because developers could use this constant in a way that wasn't intended, or worse, not use it at all).
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
reviewed
Sep 12, 2025
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add a list of networks that will be treated as whitelisted not to display the warning messages in the clients (Extension/Mobile) when adding them as custom networks.
This list is starting with HyperEVM network.
References
Related to MetaMask/metamask-mobile#19167
Related to MetaMask/metamask-extension#35609
Checklist