chore: rename state and add methods to preferences controller to match already patchede code#6707
Merged
Merged
Conversation
This commit cleans up the ESLint warning thresholds by removing the entries for `NftController.ts`, which are no longer necessary. This helps maintain a cleaner configuration and focuses on relevant files.
bergarces
changed the title
bergarces
commented
Sep 24, 2025
| - **BREAKING:** Rename `openSeaEnabled` to `displayNftMedia` ([#4774](https://github.com/MetaMask/core/pull/4774)) | ||
| - **BREAKING:** Rename `setOpenSeaEnabled` to `setDisplayNftMedia` ([#4774](https://github.com/MetaMask/core/pull/4774)) | ||
| - **BREAKING:** Rename controller state property from `useMultiRpcMigration` to `showMultiRpcModal` ([#6707](https://github.com/MetaMask/core/pull/6707)) | ||
| - **BREAKING:** Rename controller method from `setUseMultiRpcMigration` to `setShowMultiRpcModal` ([#6707](https://github.com/MetaMask/core/pull/6707)) |
Contributor
Author
There was a problem hiding this comment.
These breaking changes are already patched in the mobile client, so adding them here means we can remove the patch completely after updating to this version.
mcmire
reviewed
Sep 24, 2025
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds the missing non-nft related changes of the mobile client patch to the repo.
https://github.com/MetaMask/metamask-mobile/blob/main/patches/%40metamask%2Bpreferences-controller%2B18.4.0.patch
With this PR, the
@metamask/preferences-controllerpatch on mobile can be removed completely.References
Checklist