Skip to content

Fix/subscription controller update card payment#6726

Merged
tuna1207 merged 4 commits intomainfrom
fix/subscription-controller-update-card-payment
Sep 25, 2025
Merged

Fix/subscription controller update card payment#6726
tuna1207 merged 4 commits intomainfrom
fix/subscription-controller-update-card-payment

Conversation

@tuna1207
Copy link
Copy Markdown
Member

Explanation

Correct updatePaymentMethod return redirectUrl for card payment

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@tuna1207 tuna1207 marked this pull request as ready for review September 25, 2025 10:05
@tuna1207 tuna1207 requested review from a team as code owners September 25, 2025 10:05
cursor[bot]

This comment was marked as outdated.

@tuna1207 tuna1207 enabled auto-merge (squash) September 25, 2025 10:40
@lionellbriones lionellbriones self-requested a review September 25, 2025 10:50
Copy link
Copy Markdown

@lionellbriones lionellbriones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SubscriptionControllerGetPricingAction,
SubscriptionControllerGetCryptoApproveTransactionParamsAction,
SubscriptionControllerStartSubscriptionWithCryptoAction,
SubscriptionControllerUpdatePaymentMethodAction,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Export Causes TypeScript Compilation Errors

The UpdatePaymentMethodCardResponse type is not exported from the package's index.ts. This type is part of the public return type of the updatePaymentMethod API for card payment responses. TypeScript consumers cannot properly type this response, causing compilation errors.

Fix in Cursor Fix in Web

@tuna1207 tuna1207 merged commit 7cbf2ac into main Sep 25, 2025
240 checks passed
@tuna1207 tuna1207 deleted the fix/subscription-controller-update-card-payment branch September 25, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants