chore: use price-api to fetch exchange rates in currencyRatesController #6863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahar-fehri
changed the title
sahar-fehri
force-pushed
the
fix/use-price-api-exchange-rates-instead-of-cryptocompare-in-currencyRatesController
branch
from
748a952 to
a7ce511
Compare
…cryptocompare-in-currencyRatesController
|
@metamaskbot publish-preview |
…cryptocompare-in-currencyRatesController
|
@metamaskbot publish-preview |
…cryptocompare-in-currencyRatesController
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
…cryptocompare-in-currencyRatesController
7 tasks
…cryptocompare-in-currencyRatesController
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
previously approved these changes
Oct 23, 2025
salimtb
previously approved these changes
Oct 23, 2025
…cryptocompare-in-currencyRatesController
…cryptocompare-in-currencyRatesController
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sahar-fehri
force-pushed
the
fix/use-price-api-exchange-rates-instead-of-cryptocompare-in-currencyRatesController
branch
from
db7ef9d to
d414925
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
salimtb
approved these changes
Oct 27, 2025
…cryptocompare-in-currencyRatesController
auto-merge was automatically disabled
October 28, 2025 07:37
Merge commits are not allowed on this repository
sahar-fehri
deleted the
fix/use-price-api-exchange-rates-instead-of-cryptocompare-in-currencyRatesController
branch
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 30, 2025
#36986) ## **Description** PR to introduce fetching exchangeRates from price api and fallback to crypto compare. Do not merge until this goes in MetaMask/core#6863 [](https://codespaces.new/MetaMask/metamask-extension/pull/36986?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/a8dc4ac7-9810-48a5-8fdd-19f0bc9f8b92 ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/dcb1c517-5b9c-464d-aa27-853c7c99a781 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Integrates Codefi price API into `CurrencyRateController` and includes multichain asset state in balance calculations; wires `allIgnoredAssets` across state/Sentry and bumps key deps. > > - **Rates/Controller Init**: > - Inject `CodefiTokenPricesServiceV2` into `CurrencyRateController` via `tokenPricesService`; update init and tests/mocks. > - **Selectors/Balances**: > - Add `getAllIgnoredAssets` and include `{ accountsAssets, assetsMetadata, allIgnoredAssets }` in balance and balance-change selectors (`selectBalanceForAllWallets`, etc.). > - **State/Telemetry**: > - Add `metamask.allIgnoredAssets` to app state, Sentry background/UI masks, mock states, and snapshots. > - **Dependencies**: > - Bump `@metamask/assets-controllers` to `^85.0.0` and `@metamask/controller-utils` to `^11.15.0`; remove yarn patch for controller-utils and lockfile updates. > - **Misc**: > - Update storybook test data and integration/e2e fixtures to include `allIgnoredAssets`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3ad4311. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Bernardo Garces Chapero <bernardo.chapero@consensys.net> Co-authored-by: juanmigdr <juanmi.gdr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/36986?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
PR to update the
CurrencyRatesControllerso it uses the Price API for exchange rates, with CryptoCompare as a fallback.References
Checklist
Note
CurrencyRateController now uses the Price API (with CryptoCompare fallback) via a new required tokenPricesService, and CodefiTokenPricesServiceV2 adds fetchExchangeRates.
tokenPricesService.fetchExchangeRates, with fallback to CryptoCompare; updates polling and state mapping; requires new constructor argtokenPricesService(BREAKING).ExchangeRate/ExchangeRatesByCurrencytypes and newfetchExchangeRates(args).fetchExchangeRatesusing/v1/exchange-rates, supports optional USD rate merging, retries/circuit-breaker hooks, and filtering.CurrencyRateController.test.tsto assert Price API path, fallback behavior, USD inclusion, and polling; adjust mocks across related tests to includefetchExchangeRates.CHANGELOG.mdwith breaking change and new functionality.Written by Cursor Bugbot for commit d22e0af. This will update automatically on new commits. Configure here.