Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Oct 16, 2025

Explanation

This adds eth-json-rpc-middleware to the root README dependency graph.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds @metamask/eth-json-rpc-middleware to the README packages list and dependency graph with its connections.

  • Docs (README):
    • Packages: Add @metamask/eth-json-rpc-middleware to the package list.
    • Dependency graph (mermaid):
      • Add node eth_json_rpc_middleware.
      • Add edges: eth_json_rpc_middlewareeth_block_tracker, eth_json_rpc_provider, json_rpc_engine, error_reporting_service, network_controller.
      • Add edge: network_controllereth_json_rpc_middleware.

Written by Cursor Bugbot for commit c8cf909. This will update automatically on new commits. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review October 16, 2025 18:19
@Mrtenz Mrtenz merged commit 04ef362 into main Oct 16, 2025
11 checks passed
@Mrtenz Mrtenz deleted the mrtenz/eth-json-rpc-middleware-root-readme branch October 16, 2025 18:20
network_controller --> base_controller;
network_controller --> controller_utils;
network_controller --> eth_block_tracker;
network_controller --> eth_json_rpc_middleware;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Circular Dependency in Middleware and Controller

The dependency graph now has a circular dependency between eth_json_rpc_middleware and network_controller. This invalidates the graph and can cause issues with dependency resolution and build tools.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants