Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Oct 27, 2025

Explanation

During the messenger migration period, all changes require approval from the core-platform team. This is a temporary measure to maintain control during critical migrations.

Changes:

  • Added code freeze notice to CODEOWNERS
  • Set @MetaMask/core-platform as owner of all files (*)
  • Commented out all existing ownership rules for preservation
  • Original rules can be easily restored after migrations are complete

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Temporarily assigns @MetaMask/core-platform as owner of all files and disables Yarn codeowner validation during migration.

  • CODEOWNERS:
    • Add temporary code-freeze notice and set global * @MetaMask/core-platform.
    • Comment out all previous per-package ownership rules for later restoration.
  • Tooling (Yarn constraints):
    • Disable codeowner validation by commenting out expectCodeowner invocation and implementation in yarn.config.cjs.

Written by Cursor Bugbot for commit febd307. This will update automatically on new commits. Configure here.

… owners

During the messenger migration period, all changes require approval from the core-platform team.
This is a temporary measure to maintain control during critical migrations.

Changes:
- Added code freeze notice to CODEOWNERS
- Set @MetaMask/core-platform as owner of all files (*)
- Commented out all existing ownership rules for preservation
- Original rules can be easily restored after migrations are complete
@cryptodev-2s cryptodev-2s self-assigned this Oct 27, 2025
@cryptodev-2s cryptodev-2s marked this pull request as ready for review October 27, 2025 09:10
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner October 27, 2025 09:10
mikesposito
mikesposito previously approved these changes Oct 27, 2025
Temporarily disable the expectCodeowner validation in yarn config
since all packages are now owned by core-platform through the global
rule in CODEOWNERS during the migration period.
mikesposito
mikesposito previously approved these changes Oct 27, 2025
Temporarily disable the expectCodeowner validation in yarn config
since all packages are now owned by core-platform through the global
rule in CODEOWNERS during the migration period.

- Commented out the call to expectCodeowner()
- Commented out the expectCodeowner function definition
- Commented out the cachedCodeownersFile variable
@cryptodev-2s cryptodev-2s merged commit c69c677 into main Oct 27, 2025
255 checks passed
@cryptodev-2s cryptodev-2s deleted the feat/temporary-code-freeze-for-messenger-migrations branch October 27, 2025 09:37
Gudahtt added a commit that referenced this pull request Oct 27, 2025
…ole CODEOWNERS" (#6960)

Reverts #6947

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Restores detailed CODEOWNERS mappings and re-enables codeowner
validation in Yarn constraints.
> 
> - **Repo governance**:
> - Restore detailed CODEOWNERS rules per team and package; add
ownership for `.github/` to `@MetaMask/core-platform`.
> - **Tooling (Yarn constraints)**:
>   - Re-enable `expectCodeowner` check for child workspaces.
> - Reintroduce `cachedCodeownersFile` and full `expectCodeowner`
implementation to validate package-level rules and core-platform
co-ownership of `CHANGELOG.md` and `package.json`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8dd34e9. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants