feat: skip transaction receipt check if intent complete #6950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
force-pushed
the
feat/transaction-controller-intent-complete
branch
from
d9969d2 to
6741a3b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vinistevam
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Do not wait for a transaction receipt if the intent of the transaction is marked as complete via the new
isIntentCompleteproperty onTransactionMeta.References
Checklist
Note
Introduces
isIntentCompleteonTransactionMetaand updatesPendingTransactionTrackerto mark transactions confirmed without receipt when set, with tests and changelog updates.PendingTransactionTracker.#checkTransactionnow confirms transactions immediately iftxMeta.isIntentCompleteis true, skipping receipt checks.PendingTransactionTracker.#onTransactionConfirmednow accepts an optionalreceipt; blockchain fields (baseFeePerGas,blockTimestamp,txReceipt,verifiedOnBlockchain,txParams.gasUsed) are set only when a receipt is present.isIntentCompletetoTransactionMetainsrc/types.ts.isIntentCompleteis true and adjust confirmation/update expectations.CHANGELOG.mdwith the newisIntentCompleteproperty.Written by Cursor Bugbot for commit 61e1ad6. This will update automatically on new commits. Configure here.