fix: Add name property to custom PermissionController errors
#6987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add a
nameproperty toPermissionControllercustom errors.This fixes a bug recently introduced in
@metamask/multichain-api-middleware. A recent PR (#6985) assumed thesenameproeprties were already present.References
Fixes error in #6985
Checklist
Note
Adds a base
CustomErrorto setnameon PermissionController errors, updates affected error classes and tests, and updates related changelogs (including multichain API middleware fix note).CustomErrorbase that setsname; migrate multiple custom errors to extend it (e.g.,InvalidSubjectIdentifierError,UnrecognizedSubjectError,Caveat*errors, etc.)..nameonCaveatMergeTypeMismatchErrorandEndowmentPermissionDoesNotExistErrorinsrc/errors.test.ts.CHANGELOG.mdwith “Added” entry for errornameproperty.CHANGELOG.mdwith “Fixed” entry forwallet_revokeSessionerror handling referencing changes in@metamask/permission-controller.Written by Cursor Bugbot for commit 9b0e3ed. This will update automatically on new commits. Configure here.