Skip to content

ci: Fix inconsistent lint errors #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

ci: Fix inconsistent lint errors #7078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 64 additions & 2 deletions eslint-warning-thresholds.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"packages/accounts-controller/src/AccountsController.test.ts": {
"import-x/namespace": 1
},
"packages/accounts-controller/src/utils.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 8
},
"packages/approval-controller/src/ApprovalController.test.ts": {
"import-x/order": 1,
"jest/no-conditional-in-test": 16
Expand All @@ -14,13 +17,34 @@
"n/prefer-global/text-decoder": 1,
"no-shadow": 2
},
"packages/assets-controllers/src/AccountTrackerController.ts": {
"@typescript-eslint/no-misused-promises": 4
},
"packages/assets-controllers/src/CurrencyRateController.test.ts": {
"jest/no-conditional-in-test": 1
},
"packages/assets-controllers/src/DeFiPositionsController/DeFiPositionsController.ts": {
"@typescript-eslint/no-misused-promises": 2
},
"packages/assets-controllers/src/MultichainAssetsController/MultichainAssetsController.ts": {
"@typescript-eslint/no-misused-promises": 3
},
"packages/assets-controllers/src/MultichainAssetsController/utils.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1
},
"packages/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts": {
"@typescript-eslint/no-misused-promises": 2
},
"packages/assets-controllers/src/MultichainBalancesController/MultichainBalancesController.ts": {
"@typescript-eslint/no-misused-promises": 2
},
"packages/assets-controllers/src/NftController.test.ts": {
"import-x/namespace": 9,
"jest/no-conditional-in-test": 6
},
"packages/assets-controllers/src/NftController.ts": {
"@typescript-eslint/no-misused-promises": 2
},
"packages/assets-controllers/src/NftDetectionController.test.ts": {
"import-x/namespace": 6,
"import-x/order": 3
Expand Down Expand Up @@ -50,6 +74,12 @@
"packages/assets-controllers/src/Standards/NftStandards/ERC721/ERC721Standard.ts": {
"prettier/prettier": 1
},
"packages/assets-controllers/src/TokenBalancesController.ts": {
"@typescript-eslint/no-misused-promises": 1
},
"packages/assets-controllers/src/TokenDetectionController.ts": {
"@typescript-eslint/no-misused-promises": 5
},
"packages/assets-controllers/src/TokenListController.test.ts": {
"import-x/namespace": 7,
"import-x/order": 2,
Expand Down Expand Up @@ -85,6 +115,9 @@
"packages/base-controller/src/BaseController.test.ts": {
"import-x/namespace": 13
},
"packages/bridge-status-controller/src/utils/transaction.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 2
},
"packages/build-utils/src/transforms/remove-fenced-code.test.ts": {
"import-x/order": 1
},
Expand Down Expand Up @@ -130,7 +163,8 @@
"@typescript-eslint/naming-convention": 1
},
"packages/eth-block-tracker/src/PollingBlockTracker.test.ts": {
"@typescript-eslint/naming-convention": 1
"@typescript-eslint/naming-convention": 1,
"@typescript-eslint/unbound-method": 4
},
"packages/eth-block-tracker/src/PollingBlockTracker.ts": {
"@typescript-eslint/naming-convention": 1,
Expand Down Expand Up @@ -158,6 +192,9 @@
"jsdoc/require-jsdoc": 1,
"no-restricted-syntax": 1
},
"packages/eth-json-rpc-middleware/src/block-ref-rewrite.test.ts": {
"@typescript-eslint/no-misused-promises": 3
},
"packages/eth-json-rpc-middleware/src/block-ref-rewrite.ts": {
"jsdoc/match-description": 1
},
Expand Down Expand Up @@ -247,6 +284,7 @@
"n/no-unsupported-features/node-builtins": 1
},
"packages/keyring-controller/src/KeyringController.test.ts": {
"@typescript-eslint/no-misused-promises": 1,
"jest/no-conditional-in-test": 2
},
"packages/keyring-controller/src/KeyringController.ts": {
Expand Down Expand Up @@ -290,6 +328,12 @@
"packages/message-manager/src/utils.ts": {
"@typescript-eslint/no-unused-vars": 1
},
"packages/multichain-api-middleware/src/handlers/wallet-invokeMethod.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1
},
"packages/multichain-transactions-controller/src/MultichainTransactionsController.ts": {
"@typescript-eslint/no-misused-promises": 2
},
"packages/name-controller/src/NameController.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1,
"@typescript-eslint/prefer-readonly": 2
Expand Down Expand Up @@ -321,6 +365,12 @@
"packages/name-controller/src/util.ts": {
"jsdoc/require-returns": 1
},
"packages/network-controller/src/NetworkController.ts": {
"@typescript-eslint/no-misused-promises": 1
},
"packages/notification-services-controller/src/NotificationServicesController/NotificationServicesController.ts": {
"@typescript-eslint/no-misused-promises": 1
},
"packages/permission-controller/src/PermissionController.test.ts": {
"jest/no-conditional-in-test": 4
},
Expand Down Expand Up @@ -366,6 +416,12 @@
"packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts": {
"jsdoc/tag-lines": 2
},
"packages/sample-controllers/src/sample-gas-prices-controller.ts": {
"@typescript-eslint/no-misused-promises": 1
},
"packages/sample-controllers/src/sample-gas-prices-service/sample-gas-prices-service.test.ts": {
"@typescript-eslint/no-misused-promises": 4
},
"packages/seedless-onboarding-controller/jest.environment.js": {
"n/no-unsupported-features/node-builtins": 1
},
Expand All @@ -375,9 +431,15 @@
"packages/selected-network-controller/tests/SelectedNetworkController.test.ts": {
"jest/no-conditional-in-test": 1
},
"packages/signature-controller/src/SignatureController.ts": {
"packages/shield-controller/src/ShieldController.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 1
},
"packages/shield-controller/src/backend.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 3
},
"packages/signature-controller/src/SignatureController.ts": {
"@typescript-eslint/no-unsafe-enum-comparison": 4
},
"packages/signature-controller/src/utils/normalize.ts": {
"@typescript-eslint/no-unused-vars": 1
},
Expand Down
5 changes: 0 additions & 5 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,6 @@ const config = createConfig([
languageOptions: {
parserOptions: {
tsconfigRootDir: import.meta.dirname,
project: './tsconfig.packages.json',
// Disable `projectService` because we run into out-of-memory issues.
// See this ticket for inspiration out how to solve this:
// <https://github.com/typescript-eslint/typescript-eslint/issues/1192>
projectService: false,
},
},
rules: {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@
{ "path": "./packages/user-operation-controller" }
],
"files": [],
"include": ["./types"]
"include": ["./types", "./scripts"]
Copy link
Member Author

@Gudahtt Gudahtt Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was just one gap in tsconfig.json coverage, the top-level scripts.

}
Loading