ci: Fix claims-controller errors in tsconfig.json
#7092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
tsconfig.jsonfile forclaims-controllerwas extending from the wrong file, and was referencing the wrong configurations in other packages. This caused lint errors locally in my editor, and in the PR #7078 where we are updating how type information is read by the linter.The issue was that the
tsconfig.build.jsonfiles were being referenced, which exclude test code and test files.References
The error was introduced in #7072
Checklist
Note
Switches
claims-controllerto the correcttsconfigbase, updates package references to non-build configs, and includes tests in type checking.packages/claims-controller/tsconfig.json):../../tsconfig.packages.jsoninstead of../../tsconfig.packages.build.json.../{base-controller,messenger,profile-sync-controller}/tsconfig.json(replacingtsconfig.build.json).includeto add./testsalongside../../typesand./src.Written by Cursor Bugbot for commit 26ad4a9. This will update automatically on new commits. Configure here.