Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 7, 2025

Explanation

The tsconfig.json file for claims-controller was extending from the wrong file, and was referencing the wrong configurations in other packages. This caused lint errors locally in my editor, and in the PR #7078 where we are updating how type information is read by the linter.

The issue was that the tsconfig.build.json files were being referenced, which exclude test code and test files.

References

The error was introduced in #7072

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Switches claims-controller to the correct tsconfig base, updates package references to non-build configs, and includes tests in type checking.

  • TypeScript config (packages/claims-controller/tsconfig.json):
    • Extend from ../../tsconfig.packages.json instead of ../../tsconfig.packages.build.json.
    • Update project references to ../{base-controller,messenger,profile-sync-controller}/tsconfig.json (replacing tsconfig.build.json).
    • Expand include to add ./tests alongside ../../types and ./src.

Written by Cursor Bugbot for commit 26ad4a9. This will update automatically on new commits. Configure here.

The `tsconfig.json` file for `claims-controller` was extending from the wrong
file, and was referencing the wrong configurations in other packages. This
caused lint errors locally in my editor, and in the PR #7078 where we are
updating how type information is read by the linter.

The issue was that the `tsconfig.build.json` files were being referenced,
which exclude test code and test files.
@Gudahtt Gudahtt marked this pull request as ready for review November 7, 2025 16:48
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt requested a review from a team as a code owner November 7, 2025 16:48
@Gudahtt Gudahtt merged commit 2d9f0ca into main Nov 7, 2025
275 of 276 checks passed
@Gudahtt Gudahtt deleted the fix-claims-controller-tsconfig branch November 7, 2025 16:58
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 7, 2025

Codeowner requirement bypassed because this change is not related to the business logic/domain of this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants