Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 10, 2025

Explanation

Update ESLint config packages to v14.1.0.

The rule jest/unbound-method has been temporarily disabled. This is a looser version of @typescript-eslint/unbound-method, which was already disabled. We can attempt enabling both at the same time when we're ready.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Updates ESLint config packages to 14.1.0, disables jest/unbound-method, and refreshes lint warning thresholds.

  • ESLint Config:
    • Bump @metamask/eslint-config, @metamask/eslint-config-jest, and @metamask/eslint-config-typescript to ^14.1.0 in package.json and yarn.lock.
    • In eslint.config.mjs, disable jest/unbound-method for test files.
  • Lint Warning Thresholds (eslint-warning-thresholds.json):
    • Adjust counts and remove several entries for packages/eth-block-tracker/** (e.g., drop @typescript-eslint/naming-convention thresholds and BlockTracker.ts entry).
    • Reduce @typescript-eslint/prefer-promise-reject-errors threshold in packages/json-rpc-middleware-stream/src/index.test.ts from 3 to 1.
    • Misc minor threshold updates across packages to align with new config.

Written by Cursor Bugbot for commit 917ea15. This will update automatically on new commits. Configure here.

Update ESLint config packages to v14.1.0.

The rule `jest/unbound-method` has been temporarily disabled. This is a looser
version of `@typescript-eslint/unbound-method`, which was already disabled. We
can attempt enabling both at the same time when we're ready.
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​eslint-config-jest@​14.0.0 ⏵ 14.1.099 +110079 +288 +7100
Updated@​metamask/​eslint-config@​14.0.0 ⏵ 14.1.09910085 +188 +7100
Updated@​metamask/​eslint-config-typescript@​14.0.0 ⏵ 14.1.099 +110086 +288 +4100

View full report

@Gudahtt Gudahtt marked this pull request as ready for review November 10, 2025 15:56
@Gudahtt Gudahtt merged commit 800e615 into main Nov 10, 2025
272 checks passed
@Gudahtt Gudahtt deleted the update-eslint-config branch November 10, 2025 16:06
Gudahtt added a commit that referenced this pull request Nov 10, 2025
## Explanation

These two rules were removed from our shared config. We can remove them
completely rather than suppressing these warnings.

## References

This is a follow-up to #7103

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes warning thresholds and rule entries for
`jest/no-conditional-in-test` and
`@typescript-eslint/no-unsafe-enum-comparison` across config and
thresholds.
> 
> - **ESLint config**:
> - Remove `jest/no-conditional-in-test` from test rules in
`eslint.config.mjs`.
> - Remove `@typescript-eslint/no-unsafe-enum-comparison` from
TypeScript rules in `eslint.config.mjs`.
> - **Warning thresholds**:
> - Purge occurrences of `jest/no-conditional-in-test` and
`@typescript-eslint/no-unsafe-enum-comparison` across
`eslint-warning-thresholds.json`.
> - Minor cleanup of related per-file entries (retaining other
warnings).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
ebee223. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants