Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 10, 2025

Explanation

These two rules were removed from our shared config. We can remove them completely rather than suppressing these warnings.

References

This is a follow-up to #7103

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Removes warning thresholds and rule entries for jest/no-conditional-in-test and @typescript-eslint/no-unsafe-enum-comparison across config and thresholds.

  • ESLint config:
    • Remove jest/no-conditional-in-test from test rules in eslint.config.mjs.
    • Remove @typescript-eslint/no-unsafe-enum-comparison from TypeScript rules in eslint.config.mjs.
  • Warning thresholds:
    • Purge occurrences of jest/no-conditional-in-test and @typescript-eslint/no-unsafe-enum-comparison across eslint-warning-thresholds.json.
    • Minor cleanup of related per-file entries (retaining other warnings).

Written by Cursor Bugbot for commit ebee223. This will update automatically on new commits. Configure here.

These two rules were removed from our shared config. We can remove them
completely rather than suppressing these warnings.
@Gudahtt Gudahtt marked this pull request as ready for review November 10, 2025 21:36
@Gudahtt Gudahtt enabled auto-merge (squash) November 10, 2025 21:37
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ede586f into main Nov 10, 2025
275 checks passed
@Gudahtt Gudahtt deleted the disable-warnings-for-removed-rules branch November 10, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants