-
-
Notifications
You must be signed in to change notification settings - Fork 254
chore: Remove unused ESLint ignore directives #7154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff1300 to
f829589
Compare
GuillaumeRx
previously approved these changes
Nov 13, 2025
f829589 to
e0486f3
Compare
GuillaumeRx
reviewed
Nov 13, 2025
Contributor
GuillaumeRx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
packages/network-controller/tests/network-client/rpc-failover.ts
Outdated
Show resolved
Hide resolved
Gudahtt
commented
Nov 13, 2025
Gudahtt
commented
Nov 13, 2025
Gudahtt
commented
Nov 13, 2025
Gudahtt
commented
Nov 13, 2025
packages/network-controller/src/rpc-service/rpc-service.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
Member
Author
|
Thanks @GuillaumeRx , great catch! I forgot to do a pass for obsolete comments. I've just self-reviewed to double check we got them all as well. They should all be removed now. |
GuillaumeRx
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Relates to #6790
These changes were extracted from the draft PR #7148
Checklist
Note
Removes redundant ESLint ignore comments (e.g.,
jest/no-conditional-in-test, related enable/disable blocks, and a strayno-var) across numerous test files without functional changes.account-tree-controller,assets-controllers,bridge-controller,bridge-status-controller,chain-agnostic-permission,controller-utils,earn-controller,eth-json-rpc-*,json-rpc-engine,network-controller,network-enablement-controller,profile-sync-controller,sample-controllers, andshield-controller./* eslint-disable jest/no-conditional-in-test */and matching enable blocks; also removes a few other unused directives (e.g.,no-var).Written by Cursor Bugbot for commit e38e3e7. This will update automatically on new commits. Configure here.