Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 13, 2025

Explanation

References

Relates to #6790

These changes were extracted from the draft PR #7148

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Removes redundant ESLint ignore comments (e.g., jest/no-conditional-in-test, related enable/disable blocks, and a stray no-var) across numerous test files without functional changes.

  • Tests cleanup:
    • Strip unused ESLint disable/enable comments across many test files in packages like account-tree-controller, assets-controllers, bridge-controller, bridge-status-controller, chain-agnostic-permission, controller-utils, earn-controller, eth-json-rpc-*, json-rpc-engine, network-controller, network-enablement-controller, profile-sync-controller, sample-controllers, and shield-controller.
    • Primarily removes /* eslint-disable jest/no-conditional-in-test */ and matching enable blocks; also removes a few other unused directives (e.g., no-var).

Written by Cursor Bugbot for commit e38e3e7. This will update automatically on new commits. Configure here.

@Gudahtt Gudahtt force-pushed the remove-unused-eslint-directives branch 3 times, most recently from cff1300 to f829589 Compare November 13, 2025 15:17
@Gudahtt Gudahtt marked this pull request as ready for review November 13, 2025 15:22
@Gudahtt Gudahtt requested review from a team as code owners November 13, 2025 15:22
GuillaumeRx
GuillaumeRx previously approved these changes Nov 13, 2025
@Gudahtt Gudahtt force-pushed the remove-unused-eslint-directives branch from f829589 to e0486f3 Compare November 13, 2025 15:30
Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

Co-authored-by: Guillaume Roux <guillaumeroux123@gmail.com>
@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 13, 2025

Thanks @GuillaumeRx , great catch! I forgot to do a pass for obsolete comments. I've just self-reviewed to double check we got them all as well. They should all be removed now.

@Gudahtt Gudahtt merged commit c459156 into main Nov 13, 2025
273 checks passed
@Gudahtt Gudahtt deleted the remove-unused-eslint-directives branch November 13, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants