Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Nov 27, 2025

Explanation

This PR removes minBalanceUSD from eligibility response.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Remove minBalanceUSD from subscription eligibility and update related tests/mocks.

  • Types:
    • Remove minBalanceUSD from SubscriptionEligibility in packages/subscription-controller/src/types.ts.
  • Tests:
    • Update mocks and expectations in packages/subscription-controller/src/SubscriptionController.test.ts and packages/subscription-controller/src/SubscriptionService.test.ts to drop minBalanceUSD from eligibility payloads and defaults.

Written by Cursor Bugbot for commit 53c0a5c. This will update automatically on new commits. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 27, 2025 06:10
@lwin-kyaw lwin-kyaw requested a review from a team as a code owner November 27, 2025 06:12
@lwin-kyaw lwin-kyaw added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit d53139a Nov 27, 2025
278 checks passed
@lwin-kyaw lwin-kyaw deleted the chore/subscription-types-update branch November 27, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants