Skip to content

chore: remove 'minBalanceUSD' from eligibility response #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2025
+1 −4
Merged

chore: remove 'minBalanceUSD' from eligibility response #7248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53c0a5c
chore: remove 'minBalanceUSD' from eligibility response
lwin-kyaw Nov 27, 2025
dc00996
chore: updated ChangeLog
lwin-kyaw Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/subscription-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Removed `minBalanceUSD` field from the `SubscriptionEligibility` type. ([#7248](https://github.com/MetaMask/core/pull/7248))
- Updated `submitShieldSubscriptionCryptoApproval` to handle change payment method transaction if subscription already existed ([#7231](https://github.com/MetaMask/core/pull/7231))
- Bump `@metamask/transaction-controller` from `^62.0.0` to `^62.3.0` ([#7215](https://github.com/MetaMask/core/pull/7215), [#7220](https://github.com/MetaMask/core/pull/7220), [#7236](https://github.com/MetaMask/core/pull/7236))
- Move peer dependencies for controller and service packages to direct dependencies ([#7209](https://github.com/MetaMask/core/pull/7209))
Expand Down
1 change: 0 additions & 1 deletion packages/subscription-controller/src/SubscriptionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,7 +1425,6 @@ describe('SubscriptionController', () => {
const MOCK_SUBSCRIPTION_ELIGIBILITY: SubscriptionEligibility = {
product: PRODUCT_TYPES.SHIELD,
canSubscribe: true,
minBalanceUSD: 100,
canViewEntryModal: true,
modalType: MODAL_TYPE.A,
cohorts: [],
Expand Down
2 changes: 0 additions & 2 deletions packages/subscription-controller/src/SubscriptionService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ function createMockEligibilityResponse(overrides = {}) {
return {
product: PRODUCT_TYPES.SHIELD,
canSubscribe: true,
minBalanceUSD: 100,
canViewEntryModal: true,
cohorts: [],
assignedCohort: null,
Expand Down Expand Up @@ -474,7 +473,6 @@ describe('SubscriptionService', () => {
handleFetchMock.mockResolvedValue([
{
product: PRODUCT_TYPES.SHIELD,
minBalanceUSD: 100,
},
]);

Expand Down
1 change: 0 additions & 1 deletion packages/subscription-controller/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ export type Cohort = {
export type SubscriptionEligibility = {
product: ProductType;
canSubscribe: boolean;
minBalanceUSD: number;
canViewEntryModal: boolean;
modalType?: ModalType;
cohorts: Cohort[];
Expand Down
Loading