feat: add token minimum balance calculation and response type #7269
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
tanguyenvn
reviewed
Nov 30, 2025
| this.#getSubscriptionBalanceAmount(price), | ||
| ); | ||
|
|
||
| const tokenDecimal = new BigNumber(10).pow(tokenPaymentInfo.decimals); |
There was a problem hiding this comment.
using tokenDecimal name is not correct here, normally tokenDecimal is 6 or 9 or 18
Member
Author
There was a problem hiding this comment.
this one is for calculating token amount so it use token decimal, price unit decimal is used in #getSubscriptionBalanceAmount (same as getTokenApproveAmount)
tanguyenvn
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR
minBillingCyclesForBalancetoProductPricetypegetTokenMinimumBalanceAmountmethod toSubscriptionControllerReferences
Checklist
Note
Add
minBillingCyclesForBalanceandgetTokenMinimumBalanceAmountto compute minimum token balance, with tests and minor docs updates.#getSubscriptionBalanceAmount(price)and publicgetTokenMinimumBalanceAmount(price, tokenPaymentInfo)to compute minimum token balance using conversion rates; throws on missing rate.#getSubscriptionPriceAmount.ProductPricewithminBillingCyclesForBalance.minBillingCyclesForBalance.getTokenMinimumBalanceAmount, including error on missing conversion rate.Written by Cursor Bugbot for commit 6e482ee. This will update automatically on new commits. Configure here.