chore: Notification controller eslint cleanup

[Prithpal-Sooriya]

Explanation

This PR addresses ESLint suppressions in packages/notification-services-controller as part of the ASSETS-2100 cleanup initiative.

• Current state and why it needs to change: The specified files had existing ESLint suppressions for @typescript-eslint/explicit-function-return-type, id-length, and @typescript-eslint/naming-convention. These suppressions needed to be resolved to improve code quality and consistency.
• Solution your changes offer and how it works:
  • In perp-notifications.ts, the createPerpOrderNotification function now has an explicit Promise<void> return type, and the catch block variable e was renamed to error to satisfy id-length.
  • In notification-api.ts and schema.ts, file-level eslint-disable @typescript-eslint/naming-convention comments were added.
• Changes whose purpose might not be obvious: The eslint-disable comments for naming-convention are intentional. schema.ts is an auto-generated file from an OpenAPI specification, and notification-api.ts defines types directly derived from an external Notification API, both of which dictate their own naming conventions (e.g., snake_case) that cannot be changed without breaking compatibility or manual intervention that would be overwritten.

References

• Fixes ASSETS-2100

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

 

---

Note

Removes ESLint suppressions by adding an explicit return type and standardizing error variable in perp-notifications.ts, adding file-level naming-convention disables to API-derived type files, and updating eslint-suppressions.json.

• Notification Services Controller:
  • services/perp-notifications.ts: Add explicit Promise<void> return type to createPerpOrderNotification; rename catch variable to error.
  • types/notification-api/notification-api.ts: Add file-level eslint-disable @typescript-eslint/naming-convention with note about external schema.
  • types/notification-api/schema.ts: Add file-level eslint-disable @typescript-eslint/naming-convention and auto-generated file note.
• ESLint suppressions:
  • Update eslint-suppressions.json to remove entries for the above files.

^{Written by Cursor Bugbot for commit 8ddabd4. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor remove this file

[cursor]

Taking a look!

 

[Prithpal-Sooriya]

@cursor update the packages/notification-services-controller/CHANGELOG.md changelog to reflect changes made.

[cursor]

Done! I've completed both requests:

1. Removed the core file - The accidental core dump file has been removed from the repository

2. Updated the changelog - Added an entry to packages/notification-services-controller/CHANGELOG.md:

## [Unreleased]

### Changed

- Improve code quality by adding explicit return types and ESLint compliance ([#7479](https://github.com/MetaMask/core/pull/7479))

The changes have been committed and pushed to the PR. This should also fix the "Check changelog" CI failure since the changelog now includes the changes made in this PR.

---

 

_{Learn more about Cursor Agents}

[Prithpal-Sooriya]

@cursor please remove the changelog changes, as these eslint changes does not impact the implementation

[cursor]

Done! I've removed the changelog entry for this PR. The ESLint cleanup changes are internal code quality improvements that don't affect the implementation, so they don't need to be documented in the changelog.

---

 

_{Learn more about Cursor Agents}