Skip to content

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Dec 17, 2025

Explanation

The CHANGELOG.md for @metamask/ramps-controller had several formatting issues that were causing CI to fail:

Additionally, the changes from #7502 rename public APIs (OnRampServiceRampsService, action types, etc.) which are breaking changes. Per semver, this requires a major version bump from 1.0.0 to 2.0.0 rather than a patch release.

This PR fixes the changelog formatting and updates the version to 2.0.0 to properly reflect the breaking nature of the API changes.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • [] I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Cleans up @metamask/ramps-controller CHANGELOG: removes dev-only entries, marks breaking API renames, and fixes PR references and entries.

  • Changelog (packages/ramps-controller/CHANGELOG.md):
    • Mark breaking changes in Unreleased for renaming OnRampServiceRampsService, OnRampEnvironmentRampsEnvironment, and action type namespace updates, with links to #7502.
    • Remove non-consumer dev entries from Added section.
    • Correct and link PR references; update Fixed entry for RampsService#getGeolocation to include #7502.

Written by Cursor Bugbot for commit d05ac8a. This will update automatically on new commits. Configure here.

@georgeweiler georgeweiler requested review from a team as code owners December 17, 2025 18:46
wachunei
wachunei previously approved these changes Dec 17, 2025
pkowalski
pkowalski previously approved these changes Dec 17, 2025
@georgeweiler georgeweiler dismissed stale reviews from pkowalski and wachunei via f75ecbd December 17, 2025 19:12
@georgeweiler georgeweiler changed the title chore(ramps-controller): bump to v2.0.0 and fix changelog formatting chore(ramps-controller): fix changelog formatting Dec 17, 2025
pkowalski
pkowalski previously approved these changes Dec 17, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgeweiler georgeweiler added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 8ef8bba Dec 17, 2025
286 checks passed
@georgeweiler georgeweiler deleted the ramps-controller-2.0.0-changelog branch December 17, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants