Add init method to ConnectivityController and make getStatus async
#7679
+132
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
force-pushed
the
add-connectivity-controller-init-method
branch
from
6b4769b to
942fa1e
Compare
- Add init() method to asynchronously fetch initial connectivity status - Change constructor to initialize with default state instead of calling getStatus - Store connectivityAdapter as private field - Update ConnectivityAdapter.getStatus() to return Promise<ConnectivityStatus> - Update tests to reflect new initialization pattern - Add comprehensive tests for init() method - Update CHANGELOG with new features and breaking changes
cryptodev-2s
force-pushed
the
add-connectivity-controller-init-method
branch
from
942fa1e to
61401be
Compare
mcmire
reviewed
Jan 20, 2026
packages/connectivity-controller/src/ConnectivityController.test.ts
Outdated
Show resolved
Hide resolved
- Remove duplicate offline test that was already covered by the comprehensive first test - Remove online test that didn't verify init() worked (default state is already online) - Keep only meaningful tests that verify actual behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces an
init()method to theConnectivityControllerthat asynchronously fetches the initial connectivity status from the adapter. The constructor now initializes with a default state (online) instead of synchronously callinggetStatus(), enabling better async initialization patterns.References
Checklist
Note
Introduces asynchronous initialization and updates adapter contract.
init()fetches initial status via adapter and updates state; controller now starts with defaultonlinestateConnectivityAdapter.getStatus()now returnsPromise<ConnectivityStatus>onConnectivityChange→setConnectivityStatusgetStatusand new initialization flow; changelog updatedWritten by Cursor Bugbot for commit 742e048. This will update automatically on new commits. Configure here.