Skip to content

Conversation

@tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Jan 26, 2026

Explanation

Subscription controller add cancel type to subscription data and cancel immediate params in cancel subscription request

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Introduces cancellation semantics and request support across controller, service, and types.

  • Adds CANCEL_TYPES and CancelType; Subscription.cancelType is now part of state
  • New CancelSubscriptionRequest (with optional cancelAtPeriodEnd) used by SubscriptionController.cancelSubscription and SubscriptionService.cancelSubscription
  • Service now POSTs { cancelAtPeriodEnd } to subscriptions/:id/cancel
  • Updated exports in index.ts to expose CancelType, CancelSubscriptionRequest, and CANCEL_TYPES
  • Tests adjusted to include cancelType and new cancel request shape; changelog updated

Written by Cursor Bugbot for commit 9505318. This will update automatically on new commits. Configure here.

@tuna1207 tuna1207 marked this pull request as ready for review January 26, 2026 09:46
@tuna1207 tuna1207 requested review from a team as code owners January 26, 2026 09:46
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 228da75 Jan 26, 2026
302 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/subscription-cancel-type branch January 26, 2026 13:14
@tuna1207
Copy link
Member Author

@metamaskbot publish-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants