fix: Estimate relay transactions separately and combine with original transaction gas at quote time#7933
Merged
fix: Estimate relay transactions separately and combine with original transaction gas at quote time#7933
Conversation
packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts
Outdated
Show resolved
Hide resolved
1227b66 to
b895a33
Compare
b895a33 to
b17637e
Compare
packages/transaction-pay-controller/src/strategy/relay/relay-submit.ts
Outdated
Show resolved
Hide resolved
da405bd to
e1cbc8b
Compare
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
matthewwalsh0
previously approved these changes
Feb 16, 2026
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
…essary code Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
…h submission, update changelog Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
…rom relay-submit.ts Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
d6c813e to
64dd2bf
Compare
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
matthewwalsh0
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Touches gas estimation and fee calculation logic for Relay post-quote flows, including EIP-7702 batching; incorrect combining could misprice fees or submit with mismatched gas limits, but changes are scoped and well-covered by unit tests.
Overview
Post-quote Relay quoting now estimates gas for relay transactions only, then separately combines the original transaction gas into
fees.sourceNetworktotals and returnedmetamask.gasLimitsso quote-time costs match whatrelay-submitwill actually batch.This introduces
combinePostQuoteGasto prepend original gas for non-7702 flows, add it into the single combined gas limit for EIP-7702 batches, prefernestedTransactions[].gasovertxParams.gas, and skip combining when the original tx has notoor no gas. Tests were updated/expanded to cover these post-quote behaviors and the fallback-gas path, and the package changelog notes the fix.Written by Cursor Bugbot for commit a63f1c1. This will update automatically on new commits. Configure here.