feat: currentCurrency added to AssetsController state#7991
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
bergarces
changed the title
bergarces
commented
Feb 19, 2026
Contributor
Author
There was a problem hiding this comment.
Currency is already included as part of the query key for cache purposes, so no changes needed in the client.
bergarces
commented
Feb 23, 2026
| dataTypes: ['price'], | ||
| assetsForPriceUpdate: Object.values(this.state.assetsBalance).flatMap( | ||
| (balances) => Object.keys(balances) as Caip19AssetId[], | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
This array is consumed by PriceDataSource and gets merged with detectedTokens. Duplicates are checked there, so no need to worry about them here.
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
salimtb
approved these changes
Feb 23, 2026
| // Only fetch prices for detected assets (assets without metadata) | ||
| // The subscription handles fetching prices for all existing assets | ||
| if (!response.detectedAssets) { | ||
| if (!response.detectedAssets && !request.assetsForPriceUpdate?.length) { |
There was a problem hiding this comment.
Price-only forceUpdate may not refetch
High Severity
PriceDataSource.assetsMiddleware now returns early unless response.detectedAssets exists or request.assetsForPriceUpdate is non-empty, so any getAssets(..., { forceUpdate: true, dataTypes: ['price'] }) call that doesn’t provide assetsForPriceUpdate can silently skip fetching and return stale prices.
Additional Locations (1)
| ), | ||
| }).catch((error) => { | ||
| log('Failed to fetch asset prices after current currency change', error); | ||
| }); |
There was a problem hiding this comment.
Currency switch can overwrite newer prices
Medium Severity
setSelectedCurrency fires an async getAssets price refresh without canceling or sequencing in-flight refreshes, so rapid currency changes can complete out of order and write older-currency price results after newer-currency results, leaving assetsPrice inconsistent with selectedCurrency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The state for
currentCurrencyis currently saved inCurrencyRateController. Since that controller is being deprecated, and we need that piece of state to be stored somewhere, it's being moved to the controller that will replace it.This PR also ensures that
PriceDataSourcegets updated with the existing currency instead of just being set up at constructor level.It also forces price updates when the selected currency changes by passing an array of assetIds that need price updates.
References
Checklist
Note
Medium Risk
Touches price fetching and persisted controller state; incorrect wiring could lead to stale or missing fiat prices after currency changes across clients.
Overview
Adds a persisted
selectedCurrency(ISO 4217, defaultusd) toAssetsControllerstate and exposessetSelectedCurrency, which triggers a one-off forced price refresh for currently-held assets when the currency changes.Refactors
PriceDataSourceto read currency dynamically via agetSelectedCurrencycallback (instead of a constructor-timecurrencyoption) and extendsDataRequestwithassetsForPriceUpdateso price middleware can fetch prices for an explicit asset list (not only newly detected assets).Written by Cursor Bugbot for commit 8afb884. This will update automatically on new commits. Configure here.