Skip to content

Comments

fix: filter out only malicious non-evm assets#8003

Merged
sahar-fehri merged 2 commits intomainfrom
fix/filter-out-only-malicious-spl-tokens
Feb 20, 2026
Merged

fix: filter out only malicious non-evm assets#8003
sahar-fehri merged 2 commits intomainfrom
fix/filter-out-only-malicious-spl-tokens

Conversation

@sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 20, 2026

Explanation

  • Narrows the Blockaid token filter in MultichainAssetsController to only remove tokens flagged as Malicious, keeping Spam, Warning, and Benign tokens
  • This is a product decision to reduce the risk of disrupting UX for memecoins and long-tail SOL assets.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes token security filtering behavior, which can affect user exposure to potentially undesirable assets if Blockaid labels them as Spam/Warning rather than Malicious.

Overview
MultichainAssetsController now only removes tokens when Blockaid’s bulkScanTokens marks them as Malicious, instead of filtering any non-Benign result.

Tests were updated/expanded to assert the new behavior (keeping Spam/Warning tokens while still filtering Malicious), and the assets-controllers changelog documents the behavioral change.

Written by Cursor Bugbot for commit cb6c2df. This will update automatically on new commits. Configure here.

@sahar-fehri sahar-fehri requested review from a team as code owners February 20, 2026 08:19
Copy link
Member

@juanmigdr juanmigdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see here this is for non-evm assets, not only SPL, is this right? Just confused by the title

@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 20, 2026
@sahar-fehri sahar-fehri changed the title fix: filter out only malicious spl tokens fix: filter out only malicious non-evm assets Feb 20, 2026
Merged via the queue into main with commit 79608bf Feb 20, 2026
310 checks passed
@sahar-fehri sahar-fehri deleted the fix/filter-out-only-malicious-spl-tokens branch February 20, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants