fix: add workspace resolutions for preview builds#8035
Merged
cryptodev-2s merged 3 commits intomainfrom Feb 25, 2026
Merged
Conversation
Ensure @metamask/* imports resolve from local workspace after packages are renamed to the preview scope, preventing build failures from unpublished type changes.
Contributor
|
@cryptodev-2s Does this change mean that all internal dependencies will resolve to preview builds now? |
Contributor
Author
No the resolutions ensure internal dependencies resolve from the checked-out workspace on CI, not from preview builds or the npm registry. |
Gudahtt
reviewed
Feb 25, 2026
scripts/prepare-preview-builds.sh
Outdated
Comment on lines
38
to
41
| resolutions="{}" | ||
| while IFS=$'\t' read -r location name; do | ||
| resolutions=$(echo "$resolutions" | jq --arg orig "$name" --arg loc "$location" '. + {($orig): ("portal:./" + $loc)}') | ||
| done < <(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(select(.location != ".")) | map([.location, .name]) | map(@tsv) | .[]') |
Member
There was a problem hiding this comment.
I think this would be a simpler way of doing the same thing:
Suggested change
| resolutions="{}" | |
| while IFS=$'\t' read -r location name; do | |
| resolutions=$(echo "$resolutions" | jq --arg orig "$name" --arg loc "$location" '. + {($orig): ("portal:./" + $loc)}') | |
| done < <(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(select(.location != ".")) | map([.location, .name]) | map(@tsv) | .[]') | |
| resolutions="$(yarn workspaces list --no-private --json | jq --slurp --raw-output 'reduce .[] as $entry ({}; .[$entry.name] = "portal:./" + $entry.location)')" |
Contributor
Author
There was a problem hiding this comment.
Yes much cleaner, fixed here 1e855a9
However is there a reason you used --raw-output the result passed the jq is a JSON object ?
Member
There was a problem hiding this comment.
Good point, the --raw-output flag seems unnecessary. I didn't mean to include it
Gudahtt
reviewed
Feb 25, 2026
scripts/prepare-preview-builds.sh
Outdated
Comment on lines
38
to
41
| resolutions="{}" | ||
| while IFS=$'\t' read -r location name; do | ||
| resolutions=$(echo "$resolutions" | jq --arg orig "$name" --arg loc "$location" '. + {($orig): ("portal:./" + $loc)}') | ||
| done < <(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(select(.location != ".")) | map([.location, .name]) | map(@tsv) | .[]') |
Member
There was a problem hiding this comment.
This strategy of using package name resolutions could still cause a build failure in cases where two different major versions of a monorepo package are used in the dependency tree. We do try to avoid that though. And at least it's certainly less broken (or less likely to cause a build failure) with this approach
Member
There was a problem hiding this comment.
For this to be more accurate, we'd have to use something like this as the resolution instead:
"@metamask/<PACKAGE_NAME>@<VERSION_RANGE>": "@metamask-previews/<PACKAGE_NAME>@<VERSION_RANGE>"
or
"@metamask/<PACKAGE_NAME>@<VERSION_RANGE>": "portal:./[location]"
(they should be equivalent).
But it would take a bit of extra work to grab the version from each package manifest
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
cryptodev-2s
deleted the
chore/add-workspace-resolutions-preview-builds
branch
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
During preview builds, packages are renamed from
@metamask/*to a preview scope. Without explicit resolutions, yarn resolves@metamask/*imports from the npm registry instead of the local workspace, causing build failures when packages contain unpublished type changes.This adds workspace resolutions to the root
package.jsoninprepare-preview-builds.shso that@metamask/*imports continue to resolve locally.References
Checklist
Note
Low Risk
Build-script-only change that adjusts dependency resolution for preview builds; risk is limited to potentially overriding existing
resolutionsbehavior in CI/preview pipelines.Overview
Preview-build preparation now injects Yarn
resolutionsinto the rootpackage.jsonbefore rewriting workspace manifests, mapping each workspace package name to a localportal:path.This prevents
@metamask/*dependencies from being pulled from the npm registry after packages are renamed to the preview scope, avoiding build failures when unpublished workspace changes (e.g., types) exist.Written by Cursor Bugbot for commit 702bd39. This will update automatically on new commits. Configure here.