Conversation
…ataSource Include all native asset IDs from NetworkEnablementController.nativeAssetIdentifiers in every fetchV3Assets call, ensuring native tokens always have up-to-date metadata regardless of whether they appear in detected assets.
salimtb
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
previously approved these changes
Mar 18, 2026
Prithpal-Sooriya
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Include all native asset IDs from NetworkEnablementController.nativeAssetIdentifiers in every fetchV3Assets call, ensuring native tokens always have up-to-date metadata regardless of whether they appear in detected assets.
References
Checklist
Note
Medium Risk
Medium risk because it changes which assets are persisted by filtering out low-occurrence non-native tokens and mutating
assetsBalance/detectedAssetsbased on API metadata, which could hide tokens unexpectedly if occurrence data is missing or incorrect.Overview
Ensures
TokenDataSourcealways fetches metadata for all native assets by injecting native CAIP-19 IDs (fromNetworkEnablementController.nativeAssetIdentifiers) into everyfetchV3Assetsrequest, even when no assets are detected.Adds a spam-reduction step that drops non-native assets with
occurrences < 3(or missing) from the metadata response and also removes those assets fromdetectedAssetsand any in-flightassetsBalanceentries. The tokens v3 metadata request now includesincludeOccurrences: true, andcore-backendexposes this newV3AssetsQueryOptions.includeOccurrencesflag; tests and changelogs are updated accordingly.Written by Cursor Bugbot for commit 1354b7a. This will update automatically on new commits. Configure here.