chore: use reusable publish-preview workflow from github-tools#8233
Merged
cryptodev-2s merged 1 commit intomainfrom Mar 18, 2026
Merged
chore: use reusable publish-preview workflow from github-tools#8233cryptodev-2s merged 1 commit intomainfrom
cryptodev-2s merged 1 commit intomainfrom
Conversation
Contributor
|
@metamaskbot publish-preview |
Contributor
Author
Unfortunately this will use the main version |
mcmire
approved these changes
Mar 18, 2026
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
I was thinking we might be able to test it in this PR, but I guess not. Anyway, LGTM.
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
## Explanation The reusable `publish-preview` workflow from `github-tools` requires `contents: read` (checkout) and `pull-requests: write` (PR comment). MetaMask's org restricts default token permissions to read-only, so these must be explicitly declared by the caller. ## References - Fixes workflow validation error from #8233 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [x] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: only updates workflow permissions, with no product code or runtime logic changes. > > **Overview** > Ensures the reusable `publish-preview` GitHub Actions workflow can run under restricted org defaults by explicitly granting `contents: read` (checkout) and `pull-requests: write` (PR commenting) permissions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit cd67686. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
micaelae
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Explanation Replace the inline preview build workflow with the reusable `publish-preview` workflow from `MetaMask/github-tools@v1` and delete old scripts that are no longer needed. ## References - MetaMask/github-tools#223 - MetaMask/github-tools#227 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [x] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > CI publishing logic is replaced with a reusable workflow, which changes how preview artifacts are built and published with an NPM token. Risk is moderate because it impacts the release pipeline, but the change is largely a refactor/removal of custom scripting. > > **Overview** > Replaces the repo’s inline `publish-preview` GitHub Actions workflow (fork checks, build/upload artifacts, manifest validation, publish, and PR commenting) with a single call to the reusable `MetaMask/github-tools` `publish-preview` workflow. > > Removes the now-unused local preview-build helper scripts (`scripts/generate-preview-build-message.ts`, `scripts/prepare-preview-builds.sh`, and `scripts/prepare-preview-builds.jq`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 183cdc7. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
micaelae
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Explanation The reusable `publish-preview` workflow from `github-tools` requires `contents: read` (checkout) and `pull-requests: write` (PR comment). MetaMask's org restricts default token permissions to read-only, so these must be explicitly declared by the caller. ## References - Fixes workflow validation error from #8233 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [x] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: only updates workflow permissions, with no product code or runtime logic changes. > > **Overview** > Ensures the reusable `publish-preview` GitHub Actions workflow can run under restricted org defaults by explicitly granting `contents: read` (checkout) and `pull-requests: write` (PR commenting) permissions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit cd67686. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the inline preview build workflow with the reusable
publish-previewworkflow fromMetaMask/github-tools@v1and delete old scripts that are no longer needed.References
Checklist
Note
Medium Risk
CI publishing logic is replaced with a reusable workflow, which changes how preview artifacts are built and published with an NPM token. Risk is moderate because it impacts the release pipeline, but the change is largely a refactor/removal of custom scripting.
Overview
Replaces the repo’s inline
publish-previewGitHub Actions workflow (fork checks, build/upload artifacts, manifest validation, publish, and PR commenting) with a single call to the reusableMetaMask/github-toolspublish-previewworkflow.Removes the now-unused local preview-build helper scripts (
scripts/generate-preview-build-message.ts,scripts/prepare-preview-builds.sh, andscripts/prepare-preview-builds.jq).Written by Cursor Bugbot for commit 183cdc7. This will update automatically on new commits. Configure here.