fix: omit balances without reliable decimals#8267
Merged
Conversation
- RpcDataSource: skip human-readable balance when decimals stay falsy after RPC - TokenDetector: skip detectedBalances when token list has no decimals - BalanceFetcher: native stays 18; ERC-20 without tokenInfos uses 1; explicit tokenInfo without decimals skips - Add unit tests for RpcDataSource, BalanceFetcher, and TokenDetector
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Made-with: Cursor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
salimtb
changed the title
bergarces
reviewed
Mar 23, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
commented
Mar 23, 2026
| /** Token decimals used for formatting */ | ||
| decimals: number; | ||
| /** Token decimals used for formatting; omitted when unknown (raw `balance` only; resolved downstream). */ | ||
| decimals?: number; |
Contributor
Author
There was a problem hiding this comment.
in theory the token api should always return decimals , in case it's not we fallback to rpc calls
salimtb
commented
Mar 23, 2026
| const rawAmount = new BigNumberJS(rawBalance); | ||
| const divisor = new BigNumberJS(10).pow(decimals); | ||
| return rawAmount.dividedBy(divisor).toString(); | ||
| return rawAmount.dividedBy(divisor).toFixed(); |
Contributor
Author
There was a problem hiding this comment.
we use default rounding on toFixed , but this can be changed
salimtb
commented
Mar 23, 2026
| }; | ||
| } | ||
| // Unknown ERC-20: omit from assetsInfo until decimals are known. | ||
| // #handleBalanceUpdate resolves decimals via RPC or omits the balance. |
Contributor
Author
There was a problem hiding this comment.
we just skip in case of non decimals
bergarces
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes core balance/token-detection behavior by no longer defaulting ERC-20 decimals to 18, which can remove balances/metadata from responses until decimals resolve and may impact downstream consumers expecting entries to exist.
Overview
Stops the EVM RPC assets pipeline from guessing ERC-20 decimals:
RpcDataSource,BalanceFetcher, andTokenDetectornow omit human-readable balances (and relatedassetsInfo/detectedBalancesentries) when decimals are unknown, rather than defaulting to18(native tokens remain18).BalanceFetchernow treats ERC-20 decimals as optional inTokenFetchInfo/AssetBalanceand passes raw balances through when decimals aren’t provided;RpcDataSourceadds#tokenFetchInfosForCustomErc20sand updates balance conversion logic to skip formatting without decimals and avoid emitting placeholder metadata. Test suites are updated/expanded to cover the new omission behavior and edge cases (missing/zero decimals).Written by Cursor Bugbot for commit 419030b. This will update automatically on new commits. Configure here.